linux-kernel - Re: [PATCH -next] btrfs: Make inc_block_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3e3b582-00a2-3006-9510-712748bd092e@suse.com>
Date:   Tue, 27 Aug 2019 16:48:34 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     YueHaibing <yuehaibing@...wei.com>, clm@...com,
        David Sterba <dsterba@...e.com>, josef@...icpanda.com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] btrfs: Make inc_block_group_ro static



On 27.08.19 г. 16:43 ч., YueHaibing wrote:
> Fix sparse warning:
> 
> fs/btrfs/block-group.c:1183:5: warning:
>  symbol 'inc_block_group_ro' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Nikolay Borisov <nborisov@...e.com>

> ---
>  fs/btrfs/block-group.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
> index 3147e84..8cc7768 100644
> --- a/fs/btrfs/block-group.c
> +++ b/fs/btrfs/block-group.c
> @@ -1180,7 +1180,7 @@ struct btrfs_trans_handle *btrfs_start_trans_remove_block_group(
>   * data in this block group. That check should be done by relocation routine,
>   * not this function.
>   */
> -int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
> +static int inc_block_group_ro(struct btrfs_block_group_cache *cache, int force)
>  {
>  	struct btrfs_space_info *sinfo = cache->space_info;
>  	u64 num_bytes;
>