linux-kernel - RE: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

Open Source and information security mailing list archives

Message-ID: <DM6PR12MB26177A7D6E572D31FC46F09E83A00@DM6PR12MB2617.namprd12.prod.outlook.com>
Date:   Tue, 27 Aug 2019 15:09:42 +0000
From:   "Othman, Ahmad" <Ahmad.Othman@....com>
To:     Alex Deucher <alexdeucher@...il.com>,
        "Wentland, Harry" <Harry.Wentland@....com>
CC:     YueHaibing <yuehaibing@...wei.com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Lakha, Bhawanpreet" <Bhawanpreet.Lakha@....com>,
        "Koo, Anthony" <Anthony.Koo@....com>,
        "Bernstein, Eric" <Eric.Bernstein@....com>,
        "Cyr, Aric" <Aric.Cyr@....com>,
        "alvin.lee3@....com" <alvin.lee3@....com>,
        "Tatla, Harmanprit" <Harmanprit.Tatla@....com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/3] drm/amd/display: remove unused function
 setFieldWithMask

Hi Alex,

There are callers in the same file "info_packet.c" 

-----Original Message-----
From: Alex Deucher <alexdeucher@...il.com> 
Sent: August 27, 2019 10:20
To: Wentland, Harry <Harry.Wentland@....com>
Cc: YueHaibing <yuehaibing@...wei.com>; Wentland, Harry <Harry.Wentland@....com>; Li, Sun peng (Leo) <Sunpeng.Li@....com>; Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; Zhou, David(ChunMing) <David1.Zhou@....com>; airlied@...ux.ie; daniel@...ll.ch; Lakha, Bhawanpreet <Bhawanpreet.Lakha@....com>; Koo, Anthony <Anthony.Koo@....com>; Othman, Ahmad <Ahmad.Othman@....com>; Bernstein, Eric <Eric.Bernstein@....com>; Cyr, Aric <Aric.Cyr@....com>; alvin.lee3@....com; Tatla, Harmanprit <Harmanprit.Tatla@....com>; dri-devel@...ts.freedesktop.org; amd-gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland <hwentlan@....com> wrote:
>
> On 2019-08-27 3:09 a.m., YueHaibing wrote:
> > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), 
> > there is no caller in tree.
> >
> > Reported-by: Hulk Robot <hulkci@...wei.com> Signed-off-by: 
> > YueHaibing <yuehaibing@...wei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@....com>
>

Applied.  Thanks!

Alex

> Harry
>
> > ---
> >  .../drm/amd/display/modules/info_packet/info_packet.c | 19 
> > -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git 
> > a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c 
> > b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > index 5f4b98d..d885d64 100644
> > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
> >       ColorimetryYCC_DP_ITU2020YCbCr  = 7,  };
> >
> > -void setFieldWithMask(unsigned char *dest, unsigned int mask, 
> > unsigned int value) -{
> > -     unsigned int shift = 0;
> > -
> > -     if (!mask || !dest)
> > -             return;
> > -
> > -     while (!((mask >> shift) & 1))
> > -             shift++;
> > -
> > -     //reset
> > -     *dest = *dest & ~mask;
> > -     //set
> > -     //dont let value span past mask
> > -     value = value & (mask >> shift);
> > -     //insert value
> > -     *dest = *dest | (value << shift);
> > -}
> > -
> >  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
> >               struct dc_info_packet *info_packet)  {
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives