linux-kernel - Re: [PATCH] RDMA/mlx5: Merge two enums into a single one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190827155239.GA15262@ziepe.ca>
Date:   Tue, 27 Aug 2019 12:52:39 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     leon@...nel.org, dledford@...hat.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: Merge two enums into a single one

On Sat, Aug 24, 2019 at 10:22:26PM +0530, Souptick Joarder wrote:
> These two enums can be merged into a single one wihtout effecting
> their caller if those were created without intension.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
>  include/uapi/rdma/mlx5-abi.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h
> index 624f5b53..c89363a 100644
> +++ b/include/uapi/rdma/mlx5-abi.h
> @@ -461,13 +461,10 @@ enum mlx5_ib_mmap_cmd {
>  	MLX5_IB_MMAP_DEVICE_MEM                 = 8,
>  };
>  
> -enum {
> -	MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
> -};
> -
>  /* Bit indexes for the mlx5_alloc_ucontext_resp.clock_info_versions bitmap */
>  enum {
>  	MLX5_IB_CLOCK_INFO_V1              = 0,
> +	MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
>  };

The enums are used in different contexts, I don't think this is an
improvement

Jason