linux-kernel - Re: [PATCH v1] kunit: fix failure to build without printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ad0a0da-d8f5-4aaa-edac-28bb2463492a@infradead.org>
Date:   Tue, 27 Aug 2019 11:58:04 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Brendan Higgins <brendanhiggins@...gle.com>, shuah@...nel.org
Cc:     kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, frowand.list@...il.com,
        sboyd@...nel.org, Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v1] kunit: fix failure to build without printk

On 8/27/19 10:49 AM, Brendan Higgins wrote:
> Previously KUnit assumed that printk would always be present, which is
> not a valid assumption to make. Fix that by ifdefing out functions which
> directly depend on printk core functions similar to what dev_printk
> does.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df@kernel.org/T/#t
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  include/kunit/test.h |  7 +++++++
>  kunit/test.c         | 41 ++++++++++++++++++++++++-----------------
>  2 files changed, 31 insertions(+), 17 deletions(-)



-- 
~Randy