linux-kernel - Re: linux-next: Tree for Aug 27 (mm/zsmalloc.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190828053041.GC526@jagdpanzerIV>
Date:   Wed, 28 Aug 2019 14:30:41 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Minchan Kim <minchan@...nel.org>,
        Nitin Gupta <ngupta@...are.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: linux-next: Tree for Aug 27 (mm/zsmalloc.c)

On (08/27/19 08:37), Randy Dunlap wrote:
> on x86_64:
> 
> In file included from ../include/linux/mmzone.h:10:0,
>                  from ../include/linux/gfp.h:6,
>                  from ../include/linux/umh.h:4,
>                  from ../include/linux/kmod.h:9,
>                  from ../include/linux/module.h:13,
>                  from ../mm/zsmalloc.c:33:
> ../mm/zsmalloc.c: In function ‘zs_create_pool’:
> ../mm/zsmalloc.c:2416:27: error: ‘struct zs_pool’ has no member named ‘migration_wait’
>   init_waitqueue_head(&pool->migration_wait);
>                            ^
> ../include/linux/wait.h:67:26: note: in definition of macro ‘init_waitqueue_head’
>    __init_waitqueue_head((wq_head), #wq_head, &__key);  \
>                           ^~~~~~~

Thanks.

I believe akpm has a patch for that build error.

===========

--- a/mm/zsmalloc.c~mm-zsmallocc-fix-build-when-config_compaction=n
+++ a/mm/zsmalloc.c
@@ -2412,7 +2412,9 @@ struct zs_pool *zs_create_pool(const cha
        if (!pool->name)
                goto err;

+#ifdef CONFIG_COMPACTION
        init_waitqueue_head(&pool->migration_wait);
+#endif

===========

	-ss