linux-kernel - RE: [PATCH v3] video: hyperv: hyperv_fb: Obtain screen resolution from Hyper-V host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <KL1P15301MB026421E7481BBC5B28E3E468BBA30@KL1P15301MB0264.APCP153.PROD.OUTLOOK.COM>
Date:   Wed, 28 Aug 2019 08:45:13 +0000
From:   Wei Hu <weh@...rosoft.com>
To:     Michael Kelley <mikelley@...rosoft.com>,
        "b.zolnierkie@...sung.com" <b.zolnierkie@...sung.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sashal@...nel.org" <sashal@...nel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>
CC:     Iouri Tarassov <iourit@...rosoft.com>
Subject: RE: [PATCH v3] video: hyperv: hyperv_fb: Obtain screen resolution
 from Hyper-V host



> -----Original Message-----
> From: Michael Kelley <mikelley@...rosoft.com>
> >
> > Beginning from Windows 10 RS5+, VM screen resolution is obtained from host.
> > The "video=hyperv_fb" boot time option is not needed, but still can be
> > used to overwrite what the host specifies. The VM resolution on the host
> > could be set by executing the powershell "set-vmvideo" command.
> >
> > v2:
> > - Implemented fallback when version negotiation failed.
> > - Defined full size for supported_resolution array.
> >
> > v3:
> > - Corrected the synthvid major and minor version comparison problem.
> 
> The changelog for v2 and v3 should actually go after the "---" below so
> that the changelog does not end up as part of the commit message.  Take
> a look at other postings to LKML for an example.
> 
[Wei Hu] 
I saw people putting v2 and vN in commit message. The git log of this file also 
contains similar lines like v2. But if you prefer I can move it after ---. 


> >
> > Signed-off-by: Iouri Tarassov <iourit@...rosoft.com>
> > Signed-off-by: Wei Hu <weh@...rosoft.com>
> > ---
> >  drivers/video/fbdev/hyperv_fb.c | 159 +++++++++++++++++++++++++++++---
> >  1 file changed, 147 insertions(+), 12 deletions(-)
> >
> >
> > +/* Check if the ver1 version is equal or greater than ver2 */
> > +static inline bool synthvid_ver_eg(u32 ver1, u32 ver2)
> 
> I'm being picky here, but I would call this synthvid_ver_ge().   In my
> experience "ge" is the shorthand for "greater than or equal", rather
> than the "eg" you have used.
> 
[Wei Hu] 
Okay.

Thanks,
Wei


> Michael
>