linux-kernel - Re: [PATCH 1/2] gpio: gpio-pca953x.c: Correct type of reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190828131330.6a28e5cc@erd988>
Date:   Wed, 28 Aug 2019 13:13:30 +0200
From:   David Jander <david@...tonic.nl>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio: gpio-pca953x.c: Correct type of reg_direction

On Wed, 28 Aug 2019 12:56:28 +0200
Bartosz Golaszewski <bgolaszewski@...libre.com> wrote:

> śr., 28 sie 2019 o 10:38 Bartosz Golaszewski
> <bgolaszewski@...libre.com> napisał(a):
> >
> > wt., 27 sie 2019 o 08:46 David Jander <david@...tonic.nl> napisał(a):  
> > >
> > > The type of reg_direction needs to match the type of the regmap, which is
> > > u8.
> > >
> > > Signed-off-by: David Jander <david@...tonic.nl>
> > > ---
> > >  drivers/gpio/gpio-pca953x.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> > > index 378b206d2dc9..30072a570bc2 100644
> > > --- a/drivers/gpio/gpio-pca953x.c
> > > +++ b/drivers/gpio/gpio-pca953x.c
> > > @@ -604,7 +604,7 @@ static void pca953x_irq_bus_sync_unlock(struct irq_data *d)
> > >         u8 new_irqs;
> > >         int level, i;
> > >         u8 invert_irq_mask[MAX_BANK];
> > > -       int reg_direction[MAX_BANK];
> > > +       u8 reg_direction[MAX_BANK];
> > >
> > >         regmap_bulk_read(chip->regmap, chip->regs->direction, reg_direction,
> > >                          NBANK(chip));
> > > @@ -679,7 +679,7 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, u8 *pending)
> > >         bool pending_seen = false;
> > >         bool trigger_seen = false;
> > >         u8 trigger[MAX_BANK];
> > > -       int reg_direction[MAX_BANK];
> > > +       u8 reg_direction[MAX_BANK];
> > >         int ret, i;
> > >
> > >         if (chip->driver_data & PCA_PCAL) {
> > > @@ -768,7 +768,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
> > >  {
> > >         struct i2c_client *client = chip->client;
> > >         struct irq_chip *irq_chip = &chip->irq_chip;
> > > -       int reg_direction[MAX_BANK];
> > > +       u8 reg_direction[MAX_BANK];
> > >         int ret, i;
> > >
> > >         if (!client->irq)
> > > --
> > > 2.19.1
> > >  
> >
> > Applied for v5.4.  
> 
> Actually the second patch depends on the first one, so moved it over to fixes.

Btw, they are both bugfixes, IMHO it would be valuable to have them in 5.3rc
if possible... there is some severe breakage there right now.

Best regards,

-- 
David Jander