lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Aug 2019 20:47:33 -0500 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Vineet Gupta <vgupta@...opsys.com> Cc: linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ARC: unwind: Mark expected switch fall-through Hi, Friendly ping: Who can take this, please? Thanks -- Gustavo On 8/20/19 8:29 PM, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: haps_hs_defconfig arc): > > arch/arc/kernel/unwind.c: In function ‘read_pointer’: > ./include/linux/compiler.h:328:5: warning: this statement may fall through [-Wimplicit-fallthrough=] > do { \ > ^ > ./include/linux/compiler.h:338:2: note: in expansion of macro ‘__compiletime_assert’ > __compiletime_assert(condition, msg, prefix, suffix) > ^~~~~~~~~~~~~~~~~~~~ > ./include/linux/compiler.h:350:2: note: in expansion of macro ‘_compiletime_assert’ > _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) > ^~~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’ > #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > ^~~~~~~~~~~~~~~~~~ > ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’ > BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > ^~~~~~~~~~~~~~~~ > arch/arc/kernel/unwind.c:573:3: note: in expansion of macro ‘BUILD_BUG_ON’ > BUILD_BUG_ON(sizeof(u32) != sizeof(value)); > ^~~~~~~~~~~~ > arch/arc/kernel/unwind.c:575:2: note: here > case DW_EH_PE_native: > ^~~~ > > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> > --- > arch/arc/kernel/unwind.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arc/kernel/unwind.c b/arch/arc/kernel/unwind.c > index 445e4d702f43..dc05a63516f5 100644 > --- a/arch/arc/kernel/unwind.c > +++ b/arch/arc/kernel/unwind.c > @@ -572,6 +572,7 @@ static unsigned long read_pointer(const u8 **pLoc, const void *end, > #else > BUILD_BUG_ON(sizeof(u32) != sizeof(value)); > #endif > + /* Fall through */ > case DW_EH_PE_native: > if (end < (const void *)(ptr.pul + 1)) > return 0; >
Powered by blists - more mailing lists