linux-kernel - Re: [PATCH v2 03/15] drivers: thermal: tsens: Add __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Aug 2019 15:04:59 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        bjorn.andersson@...aro.org, edubezval@...il.com, agross@...nel.org,
        sboyd@...nel.org, masneyb@...tation.org, marc.w.gonzalez@...e.fr,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 03/15] drivers: thermal: tsens: Add __func__
 identifier to debug statements

On Tue, Aug 27, 2019 at 05:43:59PM +0530, Amit Kucheria wrote:
> Printing the function name when enabling debugging makes logs easier to
> read.
> 
> Signed-off-by: Amit Kucheria <amit.kucheria@...aro.org>
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
> Reviewed-by: Daniel Lezcano <daniel.lezcano@...aro.org>

This should need to be manually added at each call site; it is already
built into the logging system (the f flag for dynamic debug)?


Daniel.

> ---
>  drivers/thermal/qcom/tsens-common.c | 8 ++++----
>  drivers/thermal/qcom/tsens.c        | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index c037bdf92c663..7437bfe196e50 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -42,8 +42,8 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
>  
>  	for (i = 0; i < priv->num_sensors; i++) {
>  		dev_dbg(priv->dev,
> -			"sensor%d - data_point1:%#x data_point2:%#x\n",
> -			i, p1[i], p2[i]);
> +			"%s: sensor%d - data_point1:%#x data_point2:%#x\n",
> +			__func__, i, p1[i], p2[i]);
>  
>  		priv->sensor[i].slope = SLOPE_DEFAULT;
>  		if (mode == TWO_PT_CALIB) {
> @@ -60,7 +60,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
>  		priv->sensor[i].offset = (p1[i] * SLOPE_FACTOR) -
>  				(CAL_DEGC_PT1 *
>  				priv->sensor[i].slope);
> -		dev_dbg(priv->dev, "offset:%d\n", priv->sensor[i].offset);
> +		dev_dbg(priv->dev, "%s: offset:%d\n", __func__, priv->sensor[i].offset);
>  	}
>  }
>  
> @@ -209,7 +209,7 @@ int __init init_common(struct tsens_priv *priv)
>  	if (ret)
>  		goto err_put_device;
>  	if (!enabled) {
> -		dev_err(dev, "tsens device is not enabled\n");
> +		dev_err(dev, "%s: device not enabled\n", __func__);
>  		ret = -ENODEV;
>  		goto err_put_device;
>  	}
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 542a7f8c3d962..06c6bbd69a1a7 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -127,7 +127,7 @@ static int tsens_probe(struct platform_device *pdev)
>  		of_property_read_u32(np, "#qcom,sensors", &num_sensors);
>  
>  	if (num_sensors <= 0) {
> -		dev_err(dev, "invalid number of sensors\n");
> +		dev_err(dev, "%s: invalid number of sensors\n", __func__);
>  		return -EINVAL;
>  	}
>  
> @@ -156,7 +156,7 @@ static int tsens_probe(struct platform_device *pdev)
>  
>  	ret = priv->ops->init(priv);
>  	if (ret < 0) {
> -		dev_err(dev, "tsens init failed\n");
> +		dev_err(dev, "%s: init failed\n", __func__);
>  		return ret;
>  	}
>  
> @@ -164,7 +164,7 @@ static int tsens_probe(struct platform_device *pdev)
>  		ret = priv->ops->calibrate(priv);
>  		if (ret < 0) {
>  			if (ret != -EPROBE_DEFER)
> -				dev_err(dev, "tsens calibration failed\n");
> +				dev_err(dev, "%s: calibration failed\n", __func__);
>  			return ret;
>  		}
>  	}
> -- 
> 2.17.1
>