linux-kernel - Re: [RESEND v2 1/2] dt-binding docs: sbs_sbs-battery: Addition of force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190902182354.p2o6pb4wy7bggywz@earth.universe>
Date:   Mon, 2 Sep 2019 20:23:54 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Richard Tresidder <rtresidd@...ctromag.com.au>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        kstewart@...uxfoundation.org, gregkh@...uxfoundation.org,
        tglx@...utronix.de, rfontana@...hat.com, allison@...utok.net,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND v2 1/2] dt-binding docs: sbs_sbs-battery: Addition of
 force_load binding

Hi,

On Tue, Jul 30, 2019 at 06:10:03PM +0800, Richard Tresidder wrote:
> Add device tree binding documentation for addition of force_load boolean value
> to allow loading a battery during boot even if notpresent at that time.
> 
> Signed-off-by: Richard Tresidder <rtresidd@...ctromag.com.au>
> ---
>  Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> index 4e78e51..187d7bb 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/sbs_sbs-battery.txt
> @@ -15,7 +15,8 @@ Optional properties :
>     after an external change notification.
>   - sbs,battery-detect-gpios : The gpio which signals battery detection and
>     a flag specifying its polarity.
> -
> + - sbs,force-load : Allow loading of a hot-pluggable battery when there is no
> +   GPIO detect available and the module is statically built.

This does not describe hardware configuration and is not an
acceptable DT property.

-- Sebastian

>  Example:
>  
>  	battery@b {
> @@ -24,4 +25,5 @@ Example:
>  		sbs,i2c-retry-count = <2>;
>  		sbs,poll-retry-count = <10>;
>  		sbs,battery-detect-gpios = <&gpio-controller 122 1>;
> +		sbs,force-load;
>  	}
> -- 
> 1.8.3.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)