linux-kernel - Re: "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190903064050.zsmaum4gajqjdivv@willie-the-truck>
Date:   Tue, 3 Sep 2019 07:40:51 +0100
From:   Will Deacon <will@...nel.org>
To:     Qian Cai <cai@....pw>
Cc:     Robin Murphy <robin.murphy@....com>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Joerg Roedel <jroedel@...e.de>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: "Rework enabling/disabling of ATS for PCI masters" failed to
 compile on arm64

On Mon, Sep 02, 2019 at 10:10:30PM -0400, Qian Cai wrote:
> The linux-next commit “iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters” [1] causes a compilation error when PCI_ATS=n on arm64.
> 
> [1] https://lore.kernel.org/linux-iommu/20190820154549.17018-3-will@kernel.org/
> 
> drivers/iommu/arm-smmu-v3.c:2325:35: error: no member named 'ats_cap' in 'struct pci_dev'
>         return !pdev->untrusted && pdev->ats_cap;
>                                    ~~~~  ^
> 
> For example,
> 
> Symbol: PCI_ATS [=n]
>   │ Type  : bool
>   │   Defined at drivers/pci/Kconfig:118
>   │   Depends on: PCI [=y] 
>   │   Selected by [n]: 
>   │   - PCI_IOV [=n] && PCI [=y] 
>   │   - PCI_PRI [=n] && PCI [=y]│  
>   │   - PCI_PASID [=n] && PCI [=y] │  
>   │   - AMD_IOMMU [=n] && IOMMU_SUPPORT [=y] && X86_64 && PCI [=y] && ACPI [=y]

https://lkml.kernel.org/r/20190903063028.6ryuk5dmaohi2fqa@willie-the-truck

Will