linux-kernel - "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <63FF6963-E1D9-4C65-AD2E-0E4938D08584@lca.pw>
Date:   Mon, 2 Sep 2019 22:10:30 -0400
From:   Qian Cai <cai@....pw>
To:     Will Deacon <will@...nel.org>
Cc:     Robin Murphy <robin.murphy@....com>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Joerg Roedel <jroedel@...e.de>,
        linux-arm-kernel@...ts.infradead.org
Subject: "Rework enabling/disabling of ATS for PCI masters" failed to compile
 on arm64

The linux-next commit “iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters” [1] causes a compilation error when PCI_ATS=n on arm64.

[1] https://lore.kernel.org/linux-iommu/20190820154549.17018-3-will@kernel.org/

drivers/iommu/arm-smmu-v3.c:2325:35: error: no member named 'ats_cap' in 'struct pci_dev'
        return !pdev->untrusted && pdev->ats_cap;
                                   ~~~~  ^

For example,

Symbol: PCI_ATS [=n]
  │ Type  : bool
  │   Defined at drivers/pci/Kconfig:118
  │   Depends on: PCI [=y] 
  │   Selected by [n]: 
  │   - PCI_IOV [=n] && PCI [=y] 
  │   - PCI_PRI [=n] && PCI [=y]│  
  │   - PCI_PASID [=n] && PCI [=y] │  
  │   - AMD_IOMMU [=n] && IOMMU_SUPPORT [=y] && X86_64 && PCI [=y] && ACPI [=y]