linux-kernel - Re: [PATCH] iommu: Don't use sme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mufll646.fsf@morokweng.localdomain>
Date:   Tue, 03 Sep 2019 13:03:21 -0300
From:   Thiago Jung Bauermann <bauerman@...ux.ibm.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        "Lendacky\, Thomas" <Thomas.Lendacky@....com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu: Don't use sme_active() in generic code


Joerg Roedel <joro@...tes.org> writes:

> On Tue, Sep 03, 2019 at 03:28:49PM +1000, Stephen Rothwell wrote:
>> Hi all,
>> 
>> On Mon, 2 Sep 2019 14:26:40 +0000 "Lendacky, Thomas" <Thomas.Lendacky@....com> wrote:
>> > Maybe we should make this mem_encrypt_active(), since this will probably
>> > be needed if/when an IOMMU device is eventually added to a guest, and the
>> > referenced commit below doesn't remove that call.
>> 
>> I have done that for today:
>
> Thanks Stephen and Tom. I queued the attached patch into the iommu tree
> to fix the problem.
>
> From 2896ba40d0becdb72b45f096cad70633abc014f6 Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <jroedel@...e.de>
> Date: Tue, 3 Sep 2019 15:15:44 +0200
> Subject: [PATCH] iommu: Don't use sme_active() in generic code
>
> Switch to the generic function mem_encrypt_active() because
> sme_active() is x86 specific and can't be called from
> generic code on other platforms than x86.
>
> Fixes: 2cc13bb4f59f ("iommu: Disable passthrough mode when SME is active")
> Signed-off-by: Joerg Roedel <jroedel@...e.de>

Thank you!

-- 
Thiago Jung Bauermann
IBM Linux Technology Center