linux-kernel - Re: [PATCH 5.2 143/143] hsr: implement dellink to clean up resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190904212040.GA1616@sasha-vm>
Date:   Wed, 4 Sep 2019 17:20:40 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        syzbot+c6167ec3de7def23d1e8@...kaller.appspotmail.com,
        Arvid Brodin <arvid.brodin@...en.se>,
        Cong Wang <xiyou.wangcong@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 5.2 143/143] hsr: implement dellink to clean up resources

On Wed, Sep 04, 2019 at 07:54:46PM +0200, Greg Kroah-Hartman wrote:
>From: Cong Wang <xiyou.wangcong@...il.com>
>
>commit b9a1e627405d68d475a3c1f35e685ccfb5bbe668 upstream.
>
>hsr_link_ops implements ->newlink() but not ->dellink(),
>which leads that resources not released after removing the device,
>particularly the entries in self_node_db and node_db.
>
>So add ->dellink() implementation to replace the priv_destructor.
>This also makes the code slightly easier to understand.
>
>Reported-by: syzbot+c6167ec3de7def23d1e8@...kaller.appspotmail.com
>Cc: Arvid Brodin <arvid.brodin@...en.se>
>Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
>Signed-off-by: David S. Miller <davem@...emloft.net>
>Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

If the airport gods cooperate, I'm going to queue:

edf070a0fb45a ("hsr: fix a NULL pointer deref in hsr_dev_xmit()")
311633b604063 ("hsr: switch ->dellink() to ->ndo_uninit()")

as fixes for this commit.

--
Thanks,
Sasha