linux-kernel - RE: [EXT] [PATCH] net: qed: Move static keyword to the front of declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Sep 2019 07:10:28 +0000
From:   Michal Kalderon <mkalderon@...vell.com>
To:     Krzysztof Wilczynski <kw@...ux.com>,
        Ariel Elior <aelior@...vell.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] net: qed: Move static keyword to the front of
 declaration

> From: Krzysztof Wilczynski <kswilczynski@...il.com> On Behalf Of Krzysztof
> Wilczynski
> 
> External Email
> 
> ----------------------------------------------------------------------
> Move the static keyword to the front of declaration of iwarp_state_names,
> and resolve the following compiler warning that can be seen when building
> with warnings enabled (W=1):
> 
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:385:1: warning:
>   ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> 
> Also, resolve checkpatch.pl script warning:
> 
> WARNING: static const char * array should probably be
>   static const char * const
> 
> Signed-off-by: Krzysztof Wilczynski <kw@...ux.com>
> ---
> Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
> 
>  drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> index f380fae8799d..65ec16a31658 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> @@ -382,7 +382,7 @@ qed_iwarp2roce_state(enum qed_iwarp_qp_state
> state)
>  	}
>  }
> 
> -const static char *iwarp_state_names[] = {
> +static const char * const iwarp_state_names[] = {
>  	"IDLE",
>  	"RTS",
>  	"TERMINATE",

Thanks, 

Acked-by: Michal Kalderon <michal.kalderon@...vell.com>


> --
> 2.22.1