linux-kernel - Re: [PATCH] net: qed: Move static keyword to the front of declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190905.123915.113098265973997377.davem@davemloft.net>
Date:   Thu, 05 Sep 2019 12:39:15 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     kw@...ux.com
Cc:     aelior@...vell.com, GR-everest-linux-l2@...vell.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: qed: Move static keyword to the front of
 declaration

From: Krzysztof Wilczynski <kw@...ux.com>
Date: Wed,  4 Sep 2019 16:17:30 +0200

> Move the static keyword to the front of declaration of iwarp_state_names,
> and resolve the following compiler warning that can be seen when building
> with warnings enabled (W=1):
> 
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:385:1: warning:
>   ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> 
> Also, resolve checkpatch.pl script warning:
> 
> WARNING: static const char * array should probably be
>   static const char * const
> 
> Signed-off-by: Krzysztof Wilczynski <kw@...ux.com>

Applied to net-next.