linux-kernel - Re: [PATCH 4/4] rtc: ds1347: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Sep 2019 16:18:52 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     <tony@...mide.com>, <udeep.dutt@...el.com>,
        <ashutosh.dixit@...el.com>, <gregkh@...uxfoundation.org>,
        <kishon@...com>, <jonathanh@...dia.com>, <a.zummo@...ertech.it>,
        <linux-kernel@...r.kernel.org>, <linux-rtc@...r.kernel.org>,
        <arnd@...db.de>, <lorenzo.pieralisi@....com>
Subject: Re: [PATCH 4/4] rtc: ds1347: Use PTR_ERR_OR_ZERO rather than its
 implementation

On 2019/9/5 15:39, Alexandre Belloni wrote:
> On 05/09/2019 14:43:15+0800, zhong jiang wrote:
>> PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. It is better to
>> use it directly. hence just replace it.
>>
> Unless you have a more significant contribution to this driver, I'm not
> going to apply this patch, especially since it will have to be reverted
> as soon as the probe function changes.
Anyway,  Thanks,

Sincerely,
zhong jiang
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>>  drivers/rtc/rtc-ds1347.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c
>> index d392a7b..5a64eea 100644
>> --- a/drivers/rtc/rtc-ds1347.c
>> +++ b/drivers/rtc/rtc-ds1347.c
>> @@ -151,10 +151,7 @@ static int ds1347_probe(struct spi_device *spi)
>>  	rtc = devm_rtc_device_register(&spi->dev, "ds1347",
>>  				&ds1347_rtc_ops, THIS_MODULE);
>>  
>> -	if (IS_ERR(rtc))
>> -		return PTR_ERR(rtc);
>> -
>> -	return 0;
>> +	return PTR_ERR_OR_ZERO(rtc);
>>  }
>>  
>>  static struct spi_driver ds1347_driver = {
>> -- 
>> 1.7.12.4
>>