linux-kernel - Re: [PATCH 1/3] memory: Exynos5422: minor fixes in DMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPdLhrvqR==k4a9w9cmdnwGRYaTXC1ya+vOeVaGpML0zcQ@mail.gmail.com>
Date:   Fri, 6 Sep 2019 12:51:01 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Lukasz Luba <l.luba@...tner.samsung.com>
Cc:     devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Bartłomiej Żołnierkiewicz 
        <b.zolnierkie@...sung.com>, kgene@...nel.org, mark.rutland@....com,
        robh+dt@...nel.org, Chanwoo Choi <cw00.choi@...sung.com>,
        kyungmin.park@...sung.com,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        s.nawrocki@...sung.com, myungjoo.ham@...sung.com,
        willy.mh.wolff.ml@...il.com
Subject: Re: [PATCH 1/3] memory: Exynos5422: minor fixes in DMC

On Fri, 6 Sep 2019 at 12:14, Lukasz Luba <l.luba@...tner.samsung.com> wrote:
>
> Small fixes captured by static analyzes.

Explain please what are the errors being fixed. Additionally error
message from tool might be useful.

Also:
Reported-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof

> Signed-off-by: Lukasz Luba <l.luba@...tner.samsung.com>
> ---
>  drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> index 8c2ec29a7d57..a809fa997c03 100644
> --- a/drivers/memory/samsung/exynos5422-dmc.c
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -269,7 +269,7 @@ static int exynos5_init_freq_table(struct exynos5_dmc *dmc,
>         return 0;
>
>  err_free_tables:
> -       kfree(dmc->opp);
> +       devm_kfree(dmc->dev, dmc->opp);
>  err_opp:
>         dev_pm_opp_of_remove_table(dmc->dev);
>
> @@ -732,7 +732,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
>   * statistics engine which supports only registered values. Thus, some alignment
>   * must be made.
>   */
> -unsigned long
> +static unsigned long
>  exynos5_dmc_align_init_freq(struct exynos5_dmc *dmc,
>                             unsigned long bootloader_init_freq)
>  {
> --
> 2.17.1
>