linux-kernel - Re: [PATCH v2 net] net: sonic: return NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190906.150524.1245097015817848153.davem@davemloft.net>
Date:   Fri, 06 Sep 2019 15:05:24 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     maowenan@...wei.com
Cc:     eric.dumazet@...il.com, tsbogend@...ha.franken.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 net] net: sonic: return NETDEV_TX_OK if failed to
 map buffer

From: Mao Wenan <maowenan@...wei.com>
Date: Thu, 5 Sep 2019 09:57:12 +0800

> NETDEV_TX_BUSY really should only be used by drivers that call
> netif_tx_stop_queue() at the wrong moment. If dma_map_single() is
> failed to map tx DMA buffer, it might trigger an infinite loop.
> This patch use NETDEV_TX_OK instead of NETDEV_TX_BUSY, and change
> printk to pr_err_ratelimited.
> 
> Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers")
> Signed-off-by: Mao Wenan <maowenan@...wei.com>

Applied.