linux-kernel - [PATCH] lz4: make LZ4HC_setExternalDict as non-static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190906153700.2061625-1-arnd@arndb.de>
Date:   Fri,  6 Sep 2019 17:36:51 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Arnd Bergmann <arnd@...db.de>,
        Emil Velikov <emil.l.velikov@...il.com>,
        Denis Efremov <efremov@...ux.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] lz4: make LZ4HC_setExternalDict as non-static

kbuild warns for exported static symbols. This one seems to
be meant as an external API but does not have any in-kernel
users:

WARNING: "LZ4HC_setExternalDict" [vmlinux] is a static EXPORT_SYMBOL

I suppose the function should not just get removed since it would
be nice to stay close to the upstream version of lz4hc, so just
make it global.

The modpost commit is correct, but is listed here as the one
that introduced the warning.

Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 lib/lz4/lz4hc_compress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/lz4/lz4hc_compress.c b/lib/lz4/lz4hc_compress.c
index 176f03b83e56..e1075293c009 100644
--- a/lib/lz4/lz4hc_compress.c
+++ b/lib/lz4/lz4hc_compress.c
@@ -642,7 +642,7 @@ EXPORT_SYMBOL(LZ4_loadDictHC);
 
 /* compression */
 
-static void LZ4HC_setExternalDict(
+void LZ4HC_setExternalDict(
 	LZ4HC_CCtx_internal *ctxPtr,
 	const BYTE *newBlock)
 {
-- 
2.20.0