linux-kernel - Re: [PATCH] lz4: make LZ4HC_setExternalDict as non-static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ce4f4c7-f764-8937-75bf-83a4d4c57fa7@linux.com>
Date:   Fri, 6 Sep 2019 19:21:49 +0300
From:   Denis Efremov <efremov@...ux.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Emil Velikov <emil.l.velikov@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lz4: make LZ4HC_setExternalDict as non-static

Hi,

> kbuild warns for exported static symbols. This one seems to
> be meant as an external API but does not have any in-kernel
> users:
> 
> WARNING: "LZ4HC_setExternalDict" [vmlinux] is a static EXPORT_SYMBOL
> 
> I suppose the function should not just get removed since it would
> be nice to stay close to the upstream version of lz4hc, so just
> make it global.

I'm not sure what is better here. But just in case, I sent a different
patch that removes EXPORT_SYMBOL from this function some time ago:
https://lkml.org/lkml/2019/7/8/842

I checked first that this functions is indeed static in the original lib[1]
and this symbol is not used in kernel.

[1] https://github.com/lz4/lz4/blob/dev/lib/lz4hc.c#L1054

Thanks,
Denis