linux-kernel - Re: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c41c38aa288d92502edf72f8c8f34f58c251db00.camel@linux.intel.com>
Date:   Sat, 07 Sep 2019 19:55:53 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Doug Anderson <dianders@...omium.org>,
        Sasha Levin <sashal@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "# 4.0+" <stable@...r.kernel.org>,
        Vadim Sukhomlinov <sukhomlinov@...gle.com>,
        linux-integrity@...r.kernel.org, Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH AUTOSEL 4.19 126/167] tpm: Fix TPM 1.2 Shutdown sequence
 to prevent future TPM operations

On Tue, 2019-09-03 at 09:39 -0700, Doug Anderson wrote:
> Hi,
> 
> On Tue, Sep 3, 2019 at 9:28 AM Sasha Levin <sashal@...nel.org> wrote:
> > From: Vadim Sukhomlinov <sukhomlinov@...gle.com>
> > 
> > [ Upstream commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 ]
> > 
> > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling
> > future TPM operations. TPM 1.2 behavior was different, future TPM
> > operations weren't disabled, causing rare issues. This patch ensures
> > that future TPM operations are disabled.
> > 
> > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Vadim Sukhomlinov <sukhomlinov@...gle.com>
> > [dianders: resolved merge conflicts with mainline]
> > Signed-off-by: Douglas Anderson <dianders@...omium.org>
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > ---
> >  drivers/char/tpm/tpm-chip.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Jarkko: did you deal with the issues that came up in response to my
> post?  Are you happy with this going into 4.19 stable at this point?
> I notice this has your Signed-off-by so maybe?

No I have not dealt with the issues yet. The last thing I've said about
this is:

https://lore.kernel.org/stable/20190805210501.vjtmwgxjg334vtnc@linux.intel.com/

I was actually going to look into this during the plane trip to Lissabon
tomorrow morning. I have in mind that this needs to be backported first:

db4d8cb9c9f2 ("tpm: use tpm_try_get_ops() in tpm-sysfs.c.")

/Jarkko