linux-kernel - Re: [RFC][PATCH 1/1] Carry ima measurement log for arm64 via kexec_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1567985476.4614.224.camel@linux.ibm.com>
Date:   Sun, 08 Sep 2019 19:31:16 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     prsriva <prsriva@...ux.microsoft.com>,
        Thiago Jung Bauermann <bauerman@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-integrity@...r.kernel.org, jmorris@...ei.org
Subject: Re: [RFC][PATCH 1/1] Carry ima measurement log for arm64 via
 kexec_file_load

Hi Prakhar,

On Fri, 2019-09-06 at 16:56 -0700, prsriva wrote:
> On 8/30/19 5:11 PM, Thiago Jung Bauermann wrote:
> > Hello Prakhar,
> >
> > Answering this part from the cover letter:
> >
> >> The code is in most part same as powerpc, i want to get feedback as to
> >> how/correct way to refactor the code so that cross architecture
> >> partial helpers can be put in a common place.
> 
> I started refactoring code to bring helpers under drivers/of, but
> 
> i soon reliazed the current implementation can be changed a bit
> 
> so that some of the additional functions can be sourced from
> 
> existing fdt_*/of_* functions since the fdt_ima was seeming to be
> 
> an overkill. I have done so in the V1 patch and also addressed
> 
> comments you have.
> 
> Hopefully its(v1) is a cleaner approach.
> 
> - Thanks for the review, and guidance.

"Carrying over the ima log during kexec_file_load" was originally
posted on 5/10 and 5/31 without a cover letter. On 8/29 it was
reposted as an RFC with a cover letter.  The cover letter was v1, but
the patch itself was not.  In the future, please use the "git format-
patch "-subject-prefix" option to add the version number to both the
cover letter and the patches.

The comments you received were based on the 8/29 version.  I haven't
seen anything after that. 

Mimi


> > That's a great idea. If it could go to drivers/of/ as Stephen Boyd
> > mentioned in the other email that would be great.
> >
> > More comments below.
> > -Addressed those in the v1 patch
> > Prakhar Srivastava <prsriva@...ux.microsoft.com> writes:
> >