[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 9 Sep 2019 18:55:48 +0200
From: Paolo Bonzini <pbonzini@...hat.com>
To: Stefan Hajnoczi <stefanha@...hat.com>,
Matt Lupfer <mlupfer@....com>
Cc: "mst@...hat.com" <mst@...hat.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
"virtualization@...ts.linux-foundation.org"
<virtualization@...ts.linux-foundation.org>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed
On 06/09/19 10:54, Stefan Hajnoczi wrote:
> On Thu, Sep 05, 2019 at 06:19:28PM +0000, Matt Lupfer wrote:
>> The event handler calls scsi_scan_host() when events are missed, which
>> will hotplug new LUNs. However, this function won't remove any
>> unplugged LUNs. The result is that hotunplug doesn't work properly when
>> the number of unplugged LUNs exceeds the event queue size (currently 8).
>>
>> Scan existing LUNs when events are missed to check if they are still
>> present. If not, remove them.
>>
>> Signed-off-by: Matt Lupfer <mlupfer@....com>
>> ---
>> drivers/scsi/virtio_scsi.c | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>
> Please include a changelog in future patch revisions. For example:
>
> Signed-off-by: ...
> ---
> v2:
> * Replaced magic constants with sd.h constants [Michael]
>
> Just C and virtio code review, no SCSI specifics:
>
> Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>
>
Acked-by: Paolo Bonzini <pbonzini@...hat.com>
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists