linux-kernel - Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq17e6ffukr.fsf@oracle.com>
Date:   Tue, 10 Sep 2019 22:14:12 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Matt Lupfer <mlupfer@....com>
Cc:     "mst\@redhat.com" <mst@...hat.com>,
        "jasowang\@redhat.com" <jasowang@...hat.com>,
        "pbonzini\@redhat.com" <pbonzini@...hat.com>,
        "stefanha\@redhat.com" <stefanha@...hat.com>,
        "jejb\@linux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen\@oracle.com" <martin.petersen@...cle.com>,
        "virtualization\@lists.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-scsi\@vger.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed


Matt,

> The event handler calls scsi_scan_host() when events are missed, which
> will hotplug new LUNs.  However, this function won't remove any
> unplugged LUNs.  The result is that hotunplug doesn't work properly
> when the number of unplugged LUNs exceeds the event queue size
> (currently 8).
>
> Scan existing LUNs when events are missed to check if they are still
> present.  If not, remove them.

Applied to 5.4/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering