linux-kernel - [PATCH] dmaengine: milbeaut-hdmac: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1909101200570.4379@hadrien>
Date:   Tue, 10 Sep 2019 12:02:04 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     jassisinghbrar@...il.com
cc:     dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, vkoul@...nel.org, robh+dt@...nel.org,
        masami.hiramatsu@...aro.org, orito.takao@...ionext.com,
        Jassi Brar <jaswinder.singh@...aro.org>, kbuild-all@...org
Subject: [PATCH] dmaengine: milbeaut-hdmac: fix returnvar.cocci warnings

From: kbuild test robot <lkp@...el.com>

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 7cff81f3886d ("dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms")
CC: Jassi Brar <jaswinder.singh@...aro.org>
Signed-off-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

url:    https://github.com/0day-ci/linux/commits/jassisinghbrar-gmail-com/Add-support-for-AHB-DMA-controller-on-Milbeaut-series/20190910-142047
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Please take the patch only if it's a positive warning. Thanks!

 milbeaut-hdmac.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -171,7 +171,6 @@ static irqreturn_t milbeaut_hdmac_interr
 {
 	struct milbeaut_hdmac_chan *mc = dev_id;
 	struct milbeaut_hdmac_desc *md;
-	irqreturn_t ret = IRQ_HANDLED;
 	u32 val;

 	spin_lock(&mc->vc.lock);
@@ -201,7 +200,7 @@ static irqreturn_t milbeaut_hdmac_interr

 out:
 	spin_unlock(&mc->vc.lock);
-	return ret;
+	return IRQ_HANDLED;
 }

 static void milbeaut_hdmac_free_chan_resources(struct dma_chan *chan)
@@ -289,7 +288,6 @@ static int milbeaut_hdmac_terminate_all(
 	struct virt_dma_chan *vc = to_virt_chan(chan);
 	struct milbeaut_hdmac_chan *mc = to_milbeaut_hdmac_chan(vc);
 	unsigned long flags;
-	int ret = 0;
 	u32 val;

 	LIST_HEAD(head);
@@ -311,7 +309,7 @@ static int milbeaut_hdmac_terminate_all(

 	vchan_dma_desc_free_list(vc, &head);

-	return ret;
+	return 0;
 }

 static void milbeaut_hdmac_synchronize(struct dma_chan *chan)