linux-kernel - [PATCH] dmaengine: milbeaut-hdmac: fix devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1909101202180.4379@hadrien>
Date:   Tue, 10 Sep 2019 12:03:14 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     jassisinghbrar@...il.com
cc:     dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, vkoul@...nel.org, robh+dt@...nel.org,
        masami.hiramatsu@...aro.org, orito.takao@...ionext.com,
        Jassi Brar <jaswinder.singh@...aro.org>, kbuild-all@...org
Subject: [PATCH] dmaengine: milbeaut-hdmac: fix devm_platform_ioremap_resource.cocci
 warnings

From: kbuild test robot <lkp@...el.com>

Use devm_platform_ioremap_resource helper which wraps
platform_get_resource() and devm_ioremap_resource() together.

Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci

Fixes: 7cff81f3886d ("dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms")
CC: Jassi Brar <jaswinder.singh@...aro.org>
Signed-off-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

url:    https://github.com/0day-ci/linux/commits/jassisinghbrar-gmail-com/Add-support-for-AHB-DMA-controller-on-Milbeaut-series/20190910-142047
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Please take the patch only if it's a positive warning. Thanks!

 milbeaut-hdmac.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -461,7 +461,6 @@ static int milbeaut_hdmac_probe(struct p
 	struct device *dev = &pdev->dev;
 	struct milbeaut_hdmac_device *mdev;
 	struct dma_device *ddev;
-	struct resource *res;
 	int nr_chans, ret, i;

 	nr_chans = platform_irq_count(pdev);
@@ -477,8 +476,7 @@ static int milbeaut_hdmac_probe(struct p
 	if (!mdev)
 		return -ENOMEM;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	mdev->reg_base = devm_ioremap_resource(dev, res);
+	mdev->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(mdev->reg_base))
 		return PTR_ERR(mdev->reg_base);