linux-kernel - Re: [PATCH 08/11] gpiolib: of: tease apart of_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190911171018.GT2680@smile.fi.intel.com>
Date:   Wed, 11 Sep 2019 20:10:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 08/11] gpiolib: of: tease apart of_find_gpio()

On Wed, Sep 11, 2019 at 12:52:12AM -0700, Dmitry Torokhov wrote:
> Tease apart of_find_gpio() into common function that works on the
> firmware node, and a fallback handler that works on the device
> structure, so that we can later use of_find_gpio() in
> fwnode_gpiod_get_index().

> +			desc = of_find_gpio(dev_fwnode(dev),
> +					    con_id, idx, &lookupflags);

Couple of parameters can be placed on previous line.

> +			if (desc == ERR_PTR(-ENOENT))
> +				desc = of_find_gpio_fallback(dev, con_id, idx,
> +							     &lookupflags);

> +

Do we need extra blank line?


-- 
With Best Regards,
Andy Shevchenko