linux-kernel - Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h85jnz5f.fsf@gmail.com>
Date:   Wed, 11 Sep 2019 09:08:12 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     Christopher S Hall <christopher.s.hall@...el.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs


Hi,

Richard Cochran <richardcochran@...il.com> writes:
> On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote:
>
>>  	case PTP_PEROUT_REQUEST:
>> +	case PTP_PEROUT_REQUEST2:
>
> ...
>
>> +		if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) ||
>> +			req.perout.rsv[0] || req.perout.rsv[1] ||
>> +			req.perout.rsv[2] || req.perout.rsv[3]) &&
>> +			cmd == PTP_PEROUT_REQUEST2) {
>> +			err = -EINVAL;
>> +			break;
>
> ...
>
>> +/*
>> + * Bits of the ptp_perout_request.flags field:
>> + */
>> +#define PTP_PEROUT_VALID_FLAGS (~0)
>
> I think you meant (0) here, or I am confused...

Argh. What a brain fart!

Sorry about that. I'll go fix that ASAP.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)