linux-kernel - Re: [PATCH 6/6] selftests: add clone3 to TARGETS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bbd08bf-3500-40c7-ca15-06d0c84b596f@kernel.org>
Date:   Mon, 16 Sep 2019 10:48:37 -0600
From:   shuah <shuah@...nel.org>
To:     Eugene Syromiatnikov <esyr@...hat.com>,
        linux-kernel@...r.kernel.org,
        Christian Brauner <christian@...uner.io>,
        linux-kselftest@...r.kernel.org
Cc:     Adrian Reber <areber@...hat.com>, shuah <shuah@...nel.org>
Subject: Re: [PATCH 6/6] selftests: add clone3 to TARGETS

On 9/10/19 6:03 AM, Eugene Syromiatnikov wrote:
> * tools/testing/selftests/Makefile (TARGETS): Add clone3.

Again. No filenames in the commit log. Please add more detail.


"Adding clone3() tests to kselftest default run and details
on what this tests"

This will be helpful to users.

> 
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>
> ---
>   tools/testing/selftests/Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 25b43a8c..05163e4 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -4,6 +4,7 @@ TARGETS += bpf
>   TARGETS += breakpoints
>   TARGETS += capabilities
>   TARGETS += cgroup
> +TARGETS += clone3
>   TARGETS += cpufreq
>   TARGETS += cpu-hotplug
>   TARGETS += drivers/dma-buf
> 

Please make sure the test doesn't hang and all the use-cases listed
in the kselftest.rst are supported.

make kselftest
make -C tools/testing/selftests
O= and KBUILD_OUTPUT cases as well as running make directly
in the clode3 dir.

Please include test output and usage instructions if any to this
commit log as this is the patch that enables it in the default run.

thanks,
-- Shuah