linux-kernel - Re: [PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.21.1909162356500.10273@planxty>
Date:   Mon, 16 Sep 2019 23:57:32 +0200 (CEST)
From:   John Kacur <jkacur@...hat.com>
To:     Sultan Alsawaf <sultan@...neltoast.com>
cc:     linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org,
        sebastian@...akpoint.cc, tglx@...utronix.de, rostedt@...dmis.org
Subject: Re: [PATCH] rt-tests: backfire: Don't include asm/uaccess.h
 directly



On Tue, 3 Sep 2019, Sultan Alsawaf wrote:

> From: Sultan Alsawaf <sultan@...neltoast.com>
> 
> Architecture-specific uaccess.h headers can have dependencies on
> linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly.
> Since linux/uaccess.h includes asm/uaccess.h, just do that instead.
> 
> This fixes compile errors with certain kernels and architectures.
> 
> Signed-off-by: Sultan Alsawaf <sultan@...neltoast.com>
> ---
>  src/backfire/backfire.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/backfire/backfire.c b/src/backfire/backfire.c
> index aaf9c4a..a8ac9f5 100644
> --- a/src/backfire/backfire.c
> +++ b/src/backfire/backfire.c
> @@ -30,8 +30,8 @@
>  #include <linux/miscdevice.h>
>  #include <linux/proc_fs.h>
>  #include <linux/spinlock.h>
> +#include <linux/uaccess.h>
>  
> -#include <asm/uaccess.h>
>  #include <asm/system.h>
>  
>  #define BACKFIRE_MINOR MISC_DYNAMIC_MINOR
> -- 
> 2.23.0
> 
> 

Signed-off-by: John Kacur <jkacur@...hat.com>
But please in the future
1. Don't cc lkml on this
2. Include the maintainers in your patch

Thanks