linux-kernel - [PATCH v2 2/3] i2c: qup: Remove dev_err() log after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190917172120.GA11581@SD>
Date:   Tue, 17 Sep 2019 22:51:20 +0530
From:   Saiyam Doshi <saiyamdoshi.in@...il.com>
To:     agross@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, markus.elfring@....de
Subject: [PATCH v2 2/3] i2c: qup: Remove dev_err() log after
 platform_get_irq*() failure

The debug message after platform_get_irq() failure is redundant
because platform_get_irq() already prints an error. Thus remove it.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Saiyam Doshi <saiyamdoshi.in@...il.com>
---
Changes in v2:
Updated changelog and removed unnecessary braces after if condition.

 drivers/i2c/busses/i2c-qup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 5519c19bfd9c..ed09a59066b2 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -1766,10 +1766,8 @@ static int qup_i2c_probe(struct platform_device *pdev)
 		return PTR_ERR(qup->base);

 	qup->irq = platform_get_irq(pdev, 0);
-	if (qup->irq < 0) {
-		dev_err(qup->dev, "No IRQ defined\n");
+	if (qup->irq < 0)
 		return qup->irq;
-	}

 	if (has_acpi_companion(qup->dev)) {
 		ret = device_property_read_u32(qup->dev,
--
2.20.1