linux-kernel - Re: [GIT pull] x86/pti for 5.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjQJaNbQe3fmFU19_wawkx-WT9Sv=h5mWCA9=LL34g_3Q@mail.gmail.com>
Date:   Tue, 17 Sep 2019 11:13:20 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Song Liu <songliubraving@...com>,
        Ingo Molnar <mingo@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Cc:     Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [GIT pull] x86/pti for 5.4-rc1

On Mon, Sep 16, 2019 at 6:38 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>
>   - Handle unaligned addresses gracefully in pti_clone_pagetable(). Not an
>     issue with current callers, but a correctness problem. Adds a warning
>     so any caller which hands in an unaligned address gets pointed out
>     clearly.

Hmm. I actually thing this one is incomplete.

Yes, it does it correctly now for the "those addresses are missing" cases.

But if somebody passes in an unaligned address, it still does the
wrong thing for the

                if (pmd_large(*pmd) || level == PTI_CLONE_PMD) {

case. No?

I've pulled this, since the change is not _wrong_, but it does look
incomplete to me. Am I missing something?

Also, it would have been lovely to have some background on how this
was even noticed. The link in the commit message goes to the
development thread, but that one doesn't have the original report from
Song either.

                Linus