linux-kernel - Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190917181415.GA8472@linux.intel.com>
Date:   Tue, 17 Sep 2019 21:14:15 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Sumit Garg <sumit.garg@...aro.org>
Cc:     dhowells@...hat.com, peterhuewe@....de, keyrings@...r.kernel.org,
        linux-integrity@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-security-module@...r.kernel.org, herbert@...dor.apana.org.au,
        davem@...emloft.net, jgg@...pe.ca, arnd@...db.de,
        gregkh@...uxfoundation.org, jejb@...ux.ibm.com,
        zohar@...ux.ibm.com, jmorris@...ei.org, serge@...lyn.com,
        jsnitsel@...hat.com, linux-kernel@...r.kernel.org,
        daniel.thompson@...aro.org
Subject: Re: [Patch v6 4/4] KEYS: trusted: Move TPM2 trusted keys code

On Mon, Sep 16, 2019 at 04:04:24PM +0530, Sumit Garg wrote:
> Move TPM2 trusted keys code to trusted keys subsystem. The reason
> being it's better to consolidate all the trusted keys code to a single
> location so that it can be maintained sanely.
> 
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@...aro.org>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>

This commit has couple of issues that I only noticed when looking into
bug reported by Mimi.

Right now tpm_send() is the exported function that is used by other
subsystems. tpm_transmit_cmd() is an internal function. This commit adds
two unrelated code paths to send TPM commands, which is unacceptable.

You should make tpm2 functionality to use tpm_send() instead and remove
tpm_seal_trusted() and tpm_unseal_trusted() completely in this commit.

/Jarkko