linux-kernel - Re: [PATCH] staging: exfat: add exfat filesystem code to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190918110548.GA1894362@kroah.com>
Date:   Wed, 18 Sep 2019 13:05:48 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ju Hyung Park <qkrwngud825@...il.com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        devel@...verdev.osuosl.org, linkinjeon@...il.com,
        Valdis Kletnieks <valdis.kletnieks@...edu>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Namjae Jeon <namjae.jeon@...sung.com>,
        linux-kernel@...r.kernel.org, alexander.levin@...rosoft.com,
        sergey.senozhatsky@...il.com, linux-fsdevel@...r.kernel.org,
        sj1557.seo@...sung.com
Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to

On Wed, Sep 18, 2019 at 07:46:25PM +0900, Ju Hyung Park wrote:
> On Wed, Sep 18, 2019 at 7:09 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
> > Use Kconfig.
> 
> Not just that.
> There are a lot of non-static functions that's not marked ex/sdfat-specific.
> (which we would have to clean it up eventually)

Then clean them up :)

> Even with sdFAT base, there are some non-static functions named as exfat.

Then just force both filesystems to only be built as a module and all
should be fine, right?

> Figuring out a solution for this is pretty pointless imho when one of
> the drivers will be dropped soon(ish) anyways.

Given we only have one filesytem that is submitted in patch form, I
think people are making a lot of noise over nothing :)

thanks,

greg k-h