linux-kernel - Re: [PATCH v2 4/6] platform/x86: huawei-wmi: Add battery charging thresholds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Sep 2019 11:08:12 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ayman Bagabas <ayman.bagabas@...il.com>
Cc:     kbuild-all@...org, Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Ayman Bagabas <ayman.bagabas@...il.com>,
        Mattias Jacobsson <2pi@....nu>, Takashi Iwai <tiwai@...e.de>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/6] platform/x86: huawei-wmi: Add battery charging
 thresholds

Hi Ayman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Ayman-Bagabas/platform-x86-Huawei-WMI-laptop-extras-driver/20190919-090022
config: x86_64-randconfig-s1-201937 (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/platform/x86/asus-wmi.o: in function `asus_wmi_battery_init':
   drivers/platform/x86/asus-wmi.c:457: undefined reference to `battery_hook_register'
   ld: drivers/platform/x86/asus-wmi.o: in function `asus_wmi_battery_exit':
   drivers/platform/x86/asus-wmi.c:464: undefined reference to `battery_hook_unregister'
   ld: drivers/platform/x86/huawei-wmi.o: in function `huawei_wmi_battery_exit':
>> drivers/platform/x86/huawei-wmi.c:513: undefined reference to `battery_hook_unregister'
   ld: drivers/platform/x86/huawei-wmi.o: in function `huawei_wmi_battery_setup':
>> drivers/platform/x86/huawei-wmi.c:504: undefined reference to `battery_hook_register'

vim +513 drivers/platform/x86/huawei-wmi.c

   493	
   494	static void huawei_wmi_battery_setup(struct device *dev)
   495	{
   496		struct huawei_wmi *huawei = dev_get_drvdata(dev);
   497	
   498		huawei->battery_available = true;
   499		if (huawei_wmi_battery_get(NULL, NULL)) {
   500			huawei->battery_available = false;
   501			return;
   502		}
   503	
 > 504		battery_hook_register(&huawei_wmi_battery_hook);
   505		device_create_file(dev, &dev_attr_charge_control_thresholds);
   506	}
   507	
   508	static void huawei_wmi_battery_exit(struct device *dev)
   509	{
   510		struct huawei_wmi *huawei = dev_get_drvdata(dev);
   511	
   512		if (huawei->battery_available) {
 > 513			battery_hook_unregister(&huawei_wmi_battery_hook);
   514			device_remove_file(dev, &dev_attr_charge_control_thresholds);
   515		}
   516	}
   517	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (34230 bytes)