linux-kernel - Re: [PATCH v2 3/6] platform/x86: huawei-wmi: Implement huawei wmi management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201909191127.cLc5eTZR%lkp@intel.com>
Date:   Thu, 19 Sep 2019 11:22:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ayman Bagabas <ayman.bagabas@...il.com>
Cc:     kbuild-all@...org, Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Ayman Bagabas <ayman.bagabas@...il.com>,
        Takashi Iwai <tiwai@...e.de>, Mattias Jacobsson <2pi@....nu>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] platform/x86: huawei-wmi: Implement huawei wmi
 management

Hi Ayman,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3 next-20190918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Ayman-Bagabas/platform-x86-Huawei-WMI-laptop-extras-driver/20190919-090022
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/posix_types.h:5:0,
                    from include/uapi/linux/types.h:14,
                    from include/linux/compiler.h:180,
                    from include/linux/ioport.h:13,
                    from include/linux/acpi.h:12,
                    from drivers/platform/x86/huawei-wmi.c:8:
   drivers/platform/x86/huawei-wmi.c: In function 'huawei_wmi_micmute_led_set':
>> include/linux/stddef.h:8:14: warning: passing argument 3 of 'huawei_wmi_cmd' makes integer from pointer without a cast [-Wint-conversion]
    #define NULL ((void *)0)
                 ^
>> drivers/platform/x86/huawei-wmi.c:290:40: note: in expansion of macro 'NULL'
      return huawei_wmi_cmd(arg.cmd, NULL, NULL);
                                           ^~~~
   drivers/platform/x86/huawei-wmi.c:161:12: note: expected 'size_t {aka long unsigned int}' but argument is of type 'void *'
    static int huawei_wmi_cmd(u64 arg, u8 *buf, size_t buflen)
               ^~~~~~~~~~~~~~

vim +/huawei_wmi_cmd +8 include/linux/stddef.h

^1da177e4c3f41 Linus Torvalds   2005-04-16  6  
^1da177e4c3f41 Linus Torvalds   2005-04-16  7  #undef NULL
^1da177e4c3f41 Linus Torvalds   2005-04-16 @8  #define NULL ((void *)0)
6e218287432472 Richard Knutsson 2006-09-30  9  

:::::: The code at line 8 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (69878 bytes)