linux-kernel - Re: [PATCH -next] erofs: fix return value check in erofs_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Sep 2019 08:54:21 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>, Gao Xiang <xiang@...nel.org>,
        "Chao Yu" <chao@...nel.org>, Gao Xiang <gaoxiang25@...wei.com>
CC:     <linux-erofs@...ts.ozlabs.org>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] erofs: fix return value check in
 erofs_read_superblock()

On 2019/9/18 16:30, Wei Yongjun wrote:
> In case of error, the function read_mapping_page() returns
> ERR_PTR() not NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Fixes: fe7c2423570d ("erofs: use read_mapping_page instead of sb_bread")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,