linux-kernel - Re: [PATCH v2 5/9] microblaze: entry: Remove unneeded need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7131ee8e-d632-a6e4-b974-e2ad2df3bbda@arm.com>
Date:   Tue, 24 Sep 2019 11:48:31 +0100
From:   Valentin Schneider <valentin.schneider@....com>
To:     Michal Simek <monstr@...str.eu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/9] microblaze: entry: Remove unneeded need_resched()
 loop

On 24/09/2019 11:30, Michal Simek wrote:
> On 23. 09. 19 16:36, Valentin Schneider wrote:
>> Since the enabling and disabling of IRQs within preempt_schedule_irq()
>> is contained in a need_resched() loop, we don't need the outer arch
>> code loop.
>>
>> Signed-off-by: Valentin Schneider <valentin.schneider@....com>
>> Cc: Michal Simek <monstr@...str.eu>
>> ---
>>  arch/microblaze/kernel/entry.S | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/arch/microblaze/kernel/entry.S b/arch/microblaze/kernel/entry.S
>> index 4e1b567becd6..de7083bd1d24 100644
>> --- a/arch/microblaze/kernel/entry.S
>> +++ b/arch/microblaze/kernel/entry.S
>> @@ -738,14 +738,9 @@ no_intr_resched:
>>  	andi	r5, r5, _TIF_NEED_RESCHED;
>>  	beqi	r5, restore /* if zero jump over */
>>  
>> -preempt:
>>  	/* interrupts are off that's why I am calling preempt_chedule_irq */
>>  	bralid	r15, preempt_schedule_irq
>>  	nop
>> -	lwi	r11, CURRENT_TASK, TS_THREAD_INFO;	/* get thread info */
>> -	lwi	r5, r11, TI_FLAGS;		/* get flags in thread info */
>> -	andi	r5, r5, _TIF_NEED_RESCHED;
>> -	bnei	r5, preempt /* if non zero jump to resched */
>>  restore:
>>  #endif
>>  	VM_OFF /* MS: turn off MMU */
>>
> 
> Looks reasonable and also tested on HW. I expect you want me to take it
> via microblaze tree that's why applied.
> 

Yes, please. Thanks!

> Thanks,
> Michal
>