linux-kernel - Re: [PATCH 1/4] dma: Add PTDMA Engine driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <064f3abe-7d6c-0ab3-1362-61ba6b09840e@infradead.org>
Date:   Tue, 24 Sep 2019 07:35:56 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Mehta, Sanju" <Sanju.Mehta@....com>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>,
        "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>,
        "Kumar, Rajesh" <Rajesh1.Kumar@....com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: Re: [PATCH 1/4] dma: Add PTDMA Engine driver support

On 9/24/19 12:31 AM, Mehta, Sanju wrote:
> From: Sanjay R Mehta <sanju.mehta@....com>
> 
> This is the driver for the AMD passthrough DMA Engine
> 
> Signed-off-by: Sanjay R Mehta <sanju.mehta@....com>
> Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>
> Reviewed-by: Rajesh Kumar <Rajesh1.Kumar@....com>
> ---

> diff --git a/drivers/dma/ptdma/Kconfig b/drivers/dma/ptdma/Kconfig
> new file mode 100644
> index 0000000..a373431
> --- /dev/null
> +++ b/drivers/dma/ptdma/Kconfig
> @@ -0,0 +1,7 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config AMD_PTDMA
> +	tristate  "AMD Passthru DMA Engine"
> +	default m

Can you justify "default m"?  Most likely it should not be here.


> +	depends on X86_64 && PCI
> +	help
> +	  Provides the support for AMD Passthru DMA engine.


-- 
~Randy