linux-kernel - Re: [RFC PATCH] tpm: only set efi_tpm_final_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190925103854.GC6256@linux.intel.com>
Date:   Wed, 25 Sep 2019 13:38:54 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jerry Snitselaar <jsnitsel@...hat.com>
Cc:     linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org,
        Matthew Garrett <mjg59@...gle.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [RFC PATCH] tpm: only set efi_tpm_final_log_size after
 successful event log parsing

On Wed, Sep 18, 2019 at 12:16:26PM -0700, Jerry Snitselaar wrote:
> +	if (tbl_size < 0) {
> +		pr_err("Failed to parse event in TPM Final Event log\n");

FW_BUG?

> +		goto calc_out;
> +	}
> +
>  	memblock_reserve((unsigned long)final_tbl,
>  			 tbl_size + sizeof(*final_tbl));
> -	early_memunmap(final_tbl, sizeof(*final_tbl));
>  	efi_tpm_final_log_size = tbl_size;
>  
> +calc_out:
> +	early_memunmap(final_tbl, sizeof(*final_tbl));

out_calc

>  out:
>  	early_memunmap(log_tbl, sizeof(*log_tbl));
>  	return ret;
> -- 
> 2.23.0
> 

/Jarkko