linux-kernel - Re: [RFC PATCH] tpm: only set efi_tpm_final_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190925104050.GD6256@linux.intel.com>
Date:   Wed, 25 Sep 2019 13:40:50 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org,
        Matthew Garrett <mjg59@...gle.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [RFC PATCH] tpm: only set efi_tpm_final_log_size after
 successful event log parsing

On Mon, Sep 23, 2019 at 10:10:10AM -0700, Jerry Snitselaar wrote:
> Any thoughts on this? I know of at least 2 Lenovo models that are
> running into this problem.
> 
> In the case of the one I have currently have access to the problem is
> that the hash algorithm id for an event isn't one that is currently in
> the TCG registry, and it fails to find a match when walking the
> digest_sizes array. That seems like an issue for the vendor to fix in the bios,
> but we should look at the return value of tpm2_calc_event_log_size and not
> stick a negative value in efi_tpm_final_log_size.

Please use then "pr_err(FW_BUG".

Also, since you know the context you could add a comment along the
lines what you wrote.

/Jarkko