linux-kernel - Re: [PATCH] scsi: core: Log SCSI command age with errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c28778e6-62a1-b510-f6aa-fd67b54ca54c@acm.org>
Date:   Wed, 25 Sep 2019 08:45:22 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "Milan P. Gandhi" <mgandhi@...hat.com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com
Subject: Re: [PATCH] scsi: core: Log SCSI command age with errors

On 9/22/19 11:01 PM, Milan P. Gandhi wrote:
> +	off += scnprintf(logbuf + off, logbuf_len - off,
> +			 "cmd-age=%lus", cmd_age);

Have you considered to change cmd-age into cmd_age? I'm afraid otherwise 
someone might interpret the hyphen as a subtraction sign...

Thanks,

Bart.