linux-kernel - Re: [PATCH] scsi: core: Log SCSI command age with errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01be9696-b7ce-4601-0a0b-a7cbb234b1ce@redhat.com>
Date:   Thu, 26 Sep 2019 10:31:05 +0530
From:   "Milan P. Gandhi" <mgandhi@...hat.com>
To:     Bart Van Assche <bvanassche@....org>, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        Laurence Oberman <loberman@...hat.com>
Subject: Re: [PATCH] scsi: core: Log SCSI command age with errors

On 9/25/19 9:15 PM, Bart Van Assche wrote:
> On 9/22/19 11:01 PM, Milan P. Gandhi wrote:
>> +    off += scnprintf(logbuf + off, logbuf_len - off,
>> +             "cmd-age=%lus", cmd_age);
> 
> Have you considered to change cmd-age into cmd_age? I'm afraid otherwise someone might interpret the hyphen as a subtraction sign...

Thanks for your suggestion Bart.
Yes, it would be better to use cmd_age to avoid any confusion.
I will change it and send the updated patch.

Thanks,
Milan.