linux-kernel - Re: [PATCH v6 2/7] Documentation: v4l2_ctrl_new_std

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_2jXb1kcKA7+3QA2FT29qg3dOvXTZBxROk0WxTFhwFQ6g@mail.gmail.com>
Date:   Wed, 25 Sep 2019 23:00:40 +0200
From:   Ricardo Ribalda Delgado <ricardo@...alda.com>
To:     Jacopo Mondi <jacopo@...ndi.org>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH v6 2/7] Documentation: v4l2_ctrl_new_std_compound

Hi Jacopo
On Wed, Sep 25, 2019 at 10:20 AM Jacopo Mondi <jacopo@...ndi.org> wrote:
>
> Hi Ricardo,
>
> On Fri, Sep 20, 2019 at 03:51:32PM +0200, Ricardo Ribalda Delgado wrote:
> > Function for initializing compound controls with a default value.
> >
> > Suggested-by: Hans Verkuil <hverkuil@...all.nl>
> > Signed-off-by: Ricardo Ribalda Delgado <ricardo@...alda.com>
> > ---
> >  Documentation/media/kapi/v4l2-controls.rst | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/media/kapi/v4l2-controls.rst b/Documentation/media/kapi/v4l2-controls.rst
> > index ebe2a55908be..b20800cae3f2 100644
> > --- a/Documentation/media/kapi/v4l2-controls.rst
> > +++ b/Documentation/media/kapi/v4l2-controls.rst
> > @@ -140,6 +140,15 @@ Menu controls with a driver specific menu are added by calling
> >                         const struct v4l2_ctrl_ops *ops, u32 id, s32 max,
> >                         s32 skip_mask, s32 def, const char * const *qmenu);
> >
> > +Standard compound controls can be added by calling
>
> Standard compound controls with a driver provided default value can be..
>
> Or is it un-necessary to re-state it?
>

I think is a bit redundant, nothing stops you from not defining def,
if ctrl_fill has the default value for it.

> In any case:
> Reviewed-by: Jacopo Mondi <jacopo@...ndi.org>

Thanks
>
> Thanks
>   j
> > +:c:func:`v4l2_ctrl_new_std_compound`:
> > +
> > +.. code-block:: c
> > +
> > +       struct v4l2_ctrl *v4l2_ctrl_new_std_compound(struct v4l2_ctrl_handler *hdl,
> > +                       const struct v4l2_ctrl_ops *ops, u32 id,
> > +                       const union v4l2_ctrl_ptr p_def);
> > +
> >  Integer menu controls with a driver specific menu can be added by calling
> >  :c:func:`v4l2_ctrl_new_int_menu`:
> >
> > --
> > 2.23.0
> >



-- 
Ricardo Ribalda