linux-kernel - Re: [PATCH 04/32] riscv: Use pr_warn instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-77b10aea-889e-40f5-a698-b47d44ba606c@palmer-si-x1e>
Date:   Wed, 25 Sep 2019 14:05:19 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...ive.com>
To:     wangkefeng.wang@...wei.com
CC:     joe@...ches.com, akpm@...ux-foundation.org, mingo@...hat.com,
        davem@...emloft.net, acme@...hat.com, apw@...onical.com,
        peterz@...radead.org, ast@...nel.org, daniel@...earbox.net,
        Greg KH <gregkh@...uxfoundation.org>,
        sergey.senozhatsky@...il.com, pmladek@...e.com,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        wangkefeng.wang@...wei.com,
        Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu
Subject:     Re: [PATCH 04/32] riscv: Use pr_warn instead of pr_warning

On Thu, 19 Sep 2019 23:25:16 PDT (-0700), wangkefeng.wang@...wei.com wrote:
> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
> pr_warning"), removing pr_warning so all logging messages use a
> consistent <prefix>_warn style. Let's do it.
>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Palmer Dabbelt <palmer@...ive.com>
> Cc: Albert Ou <aou@...s.berkeley.edu>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>  arch/riscv/kernel/module.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/module.c b/arch/riscv/kernel/module.c
> index 70bb94ae61c5..b7401858d872 100644
> --- a/arch/riscv/kernel/module.c
> +++ b/arch/riscv/kernel/module.c
> @@ -315,8 +315,8 @@ int apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
>  			/* Ignore unresolved weak symbol */
>  			if (ELF_ST_BIND(sym->st_info) == STB_WEAK)
>  				continue;
> -			pr_warning("%s: Unknown symbol %s\n",
> -				   me->name, strtab + sym->st_name);
> +			pr_warn("%s: Unknown symbol %s\n",
> +				me->name, strtab + sym->st_name);
>  			return -ENOENT;
>  		}

Acked-by: Palmer Dabbelt <palmer@...ive.com>

I'm assuming this is going in through some other tree, LMK if that's not the 
case.