linux-kernel - Re: [PATCH v2 3/3] platform/x86: intel_oaktrail: Use pr_warn instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <627e842d-cd00-e370-643f-fcaa0222cad5@huawei.com>
Date:   Thu, 26 Sep 2019 09:28:59 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        "Andy Shevchenko" <andy@...radead.org>
Subject: Re: [PATCH v2 3/3] platform/x86: intel_oaktrail: Use pr_warn instead
 of pr_warning


On 2019/9/25 23:04, Andy Shevchenko wrote:
> On Fri, Sep 20, 2019 at 1:55 PM Kefeng Wang <wangkefeng.wang@...wei.com> wrote:
>> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
>> pr_warning"), removing pr_warning so all logging messages use a
>> consistent <prefix>_warn style. Let's do it.
>>
> You have to send to proper mailing lists and people.

Used get_maintainer.pl to find the people, and all already in the CC,  will add proper maillist into each patch.

> Don't spam the rest!
Not so clearly, should I not CC other people not in the list below?

[wkf@...alhost linux]$ ./scripts/get_maintainer.pl pr_warning/v3/0018-platform-x86-eeepc-laptop-Use-pr_warn-instead-of-pr_.patch
Corentin Chary <corentin.chary@...il.com> (maintainer:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS)
Darren Hart <dvhart@...radead.org> (odd fixer:X86 PLATFORM DRIVERS)
Andy Shevchenko <andy@...radead.org> (odd fixer:X86 PLATFORM DRIVERS)
acpi4asus-user@...ts.sourceforge.net (open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS)
platform-driver-x86@...r.kernel.org (open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS)
linux-kernel@...r.kernel.org (open list)
[wkf@...alhost linux]$ ./scripts/get_maintainer.pl pr_warning/v3/0019-platform-x86-asus-laptop-Use-pr_warn-instead-of-pr_w.patch
Corentin Chary <corentin.chary@...il.com> (maintainer:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS)
Darren Hart <dvhart@...radead.org> (odd fixer:X86 PLATFORM DRIVERS)
Andy Shevchenko <andy@...radead.org> (odd fixer:X86 PLATFORM DRIVERS)
acpi4asus-user@...ts.sourceforge.net (open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS)
platform-driver-x86@...r.kernel.org (open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS)
linux-kernel@...r.kernel.org (open list)
[wkf@...alhost linux]$ ./scripts/get_maintainer.pl pr_warning/v3/0020-platform-x86-intel_oaktrail-Use-pr_warn-instead-of-p.patch
Darren Hart <dvhart@...radead.org> (odd fixer:X86 PLATFORM DRIVERS)
Andy Shevchenko <andy@...radead.org> (odd fixer:X86 PLATFORM DRIVERS,commit_signer:2/2=100%,authored:2/2=100%,added_lines:9/9=100%,removed_lines:23/23=100%)
platform-driver-x86@...r.kernel.org (open list:X86 PLATFORM DRIVERS)
linux-kernel@...r.kernel.org (open list)

>> Cc: Corentin Chary <corentin.chary@...il.com>
>> Cc: Darren Hart <dvhart@...radead.org>
>> Cc: Andy Shevchenko <andy@...radead.org>
>> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
>> ---
>>  drivers/platform/x86/intel_oaktrail.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/platform/x86/intel_oaktrail.c b/drivers/platform/x86/intel_oaktrail.c
>> index 3c0438ba385e..1a09a75bd16d 100644
>> --- a/drivers/platform/x86/intel_oaktrail.c
>> +++ b/drivers/platform/x86/intel_oaktrail.c
>> @@ -243,7 +243,7 @@ static int oaktrail_backlight_init(void)
>>
>>         if (IS_ERR(bd)) {
>>                 oaktrail_bl_device = NULL;
>> -               pr_warning("Unable to register backlight device\n");
>> +               pr_warn("Unable to register backlight device\n");
>>                 return PTR_ERR(bd);
>>         }
>>
>> @@ -313,20 +313,20 @@ static int __init oaktrail_init(void)
>>
>>         ret = platform_driver_register(&oaktrail_driver);
>>         if (ret) {
>> -               pr_warning("Unable to register platform driver\n");
>> +               pr_warn("Unable to register platform driver\n");
>>                 goto err_driver_reg;
>>         }
>>
>>         oaktrail_device = platform_device_alloc(DRIVER_NAME, -1);
>>         if (!oaktrail_device) {
>> -               pr_warning("Unable to allocate platform device\n");
>> +               pr_warn("Unable to allocate platform device\n");
>>                 ret = -ENOMEM;
>>                 goto err_device_alloc;
>>         }
>>
>>         ret = platform_device_add(oaktrail_device);
>>         if (ret) {
>> -               pr_warning("Unable to add platform device\n");
>> +               pr_warn("Unable to add platform device\n");
>>                 goto err_device_add;
>>         }
>>
>> @@ -338,7 +338,7 @@ static int __init oaktrail_init(void)
>>
>>         ret = oaktrail_rfkill_init();
>>         if (ret) {
>> -               pr_warning("Setup rfkill failed\n");
>> +               pr_warn("Setup rfkill failed\n");
>>                 goto err_rfkill;
>>         }
>>
>> --
>> 2.20.1
>>
>