linux-kernel - Re: [PATCH v9 09/15] dt: bindings: lp55xx: Update binding for Multicolor Framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <073d1dc0-d181-59f2-6e0f-e5461e4a2b9e@ti.com>
Date:   Thu, 26 Sep 2019 07:00:38 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>, <pavel@....cz>
CC:     <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Tony Lindgren <tony@...mide.com>,
        Benoît Cousson <bcousson@...libre.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH v9 09/15] dt: bindings: lp55xx: Update binding for
 Multicolor Framework

Jacek

On 9/25/19 4:34 PM, Jacek Anaszewski wrote:
> Dan,
>
> On 9/25/19 7:46 PM, Dan Murphy wrote:
>> Update the DT binding to include the properties to use the
>> multicolor framework for the devices that use the LP55xx
>> framework.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> CC: Tony Lindgren <tony@...mide.com>
>> CC: "Benoît Cousson" <bcousson@...libre.com>
>> CC: Linus Walleij <linus.walleij@...aro.org>
>> CC: Shawn Guo <shawnguo@...nel.org>
>> CC: Sascha Hauer <s.hauer@...gutronix.de>
>> CC: Pengutronix Kernel Team <kernel@...gutronix.de>
>> CC: Fabio Estevam <festevam@...il.com>
>> CC: NXP Linux Team <linux-imx@....com>
>> ---
>>   .../devicetree/bindings/leds/leds-lp55xx.txt  | 99 +++++++++++++++++++
>>   1 file changed, 99 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>> index bfe2805c5534..c120d2bde3bd 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
>> @@ -1,6 +1,8 @@
>>   Binding for TI/National Semiconductor LP55xx LED Drivers
>>   
>>   Required properties:
>> +- #address-cells: 1
>> +- #size-cells: 0
>>   - compatible: one of
>>   	national,lp5521
>>   	national,lp5523
>> @@ -14,6 +16,18 @@ Required properties:
>>   Each child has own specific current settings
>>   - led-cur: Current setting at each LED channel (mA x10, 0 if LED is not connected)
>>   - max-cur: Maximun current at each LED channel.
>> +- reg: Output channel for the LED.  This is zero based channel identifier and
>> +	the data sheet is a one based channel identifier.
>> +	reg value to output to LED output number
>> +	D1 = reg value is 0
>> +	D2 = reg value is 1
>> +	D3 = reg value is 2
>> +	D4 = reg value is 3
>> +	D5 = reg value is 4
>> +	D6 = reg value is 5
>> +	D7 = reg value is 6
>> +	D8 = reg value is 7
>> +	D9 = reg value is 8
>>   
>>   Optional properties:
>>   - enable-gpio: GPIO attached to the chip's enable pin
>> @@ -35,23 +49,28 @@ example 1) LP5521
>>   on channel 0.
>>   
>>   lp5521@32 {
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>>   	compatible = "national,lp5521";
>>   	reg = <0x32>;
>>   	label = "lp5521_pri";
>>   	clock-mode = /bits/ 8 <2>;
>>   
>>   	chan0 {
> s/chan0/chan@0/
>
> The same applies to the remaining occurrences in this file and to
> the other patches from the patch set as already pointed out.

Ack.  I have made the same change across all the DT patches in this series

Dan


>> +		reg = <0>;
>>   		led-cur = /bits/ 8 <0x2f>;
>>   		max-cur = /bits/ 8 <0x5f>;
>>   		linux,default-trigger = "heartbeat";
>>   	};
>>