linux-kernel - Re: [PATCH] PCI: mobiveil: Fix csr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190927231504.GA13714@infradead.org>
Date:   Fri, 27 Sep 2019 16:15:04 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Andrew Murray <andrew.murray@....com>
Cc:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hou Zhiqiang <Zhiqiang.Hou@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Minghuan Lian <Minghuan.Lian@....com>,
        Subrahmanya Lingappa <l.subrahmanya@...iveil.co.in>,
        Karthikeyan Mitran <m.karthikeyan@...iveil.co.in>
Subject: Re: [PATCH] PCI: mobiveil: Fix csr_read/write build issue

On Thu, Sep 26, 2019 at 10:29:34AM +0100, Andrew Murray wrote:
> Though I'd be just as happy if the csr_[read,write][l,] functions were
> renamed to mobiveil_csr_[read,write][l,].

Please do that instead, using such generic names as csr_* in a driver
is a bad idea, with or without a __ prefix.