linux-kernel - Re: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201909271207.245jsWr2%lkp@intel.com>
Date:   Fri, 27 Sep 2019 12:17:56 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     kbuild-all@...org, KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>
Subject: Re: [PATCH v2][PATCH net] hv_netvsc: Add the support of hibernation

Hi Dexuan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Dexuan-Cui/hv_netvsc-Add-the-support-of-hibernation/20190926-061258
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> drivers/net/hyperv/netvsc_drv.c:2486:3: error: 'struct hv_driver' has no member named 'suspend'
     .suspend = netvsc_suspend,
      ^~~~~~~
>> drivers/net/hyperv/netvsc_drv.c:2486:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .suspend = netvsc_suspend,
                ^~~~~~~~~~~~~~
   drivers/net/hyperv/netvsc_drv.c:2486:13: note: (near initialization for 'netvsc_drv.shutdown')
>> drivers/net/hyperv/netvsc_drv.c:2487:3: error: 'struct hv_driver' has no member named 'resume'; did you mean 'remove'?
     .resume = netvsc_resume,
      ^~~~~~
      remove
>> drivers/net/hyperv/netvsc_drv.c:2487:12: warning: excess elements in struct initializer
     .resume = netvsc_resume,
               ^~~~~~~~~~~~~
   drivers/net/hyperv/netvsc_drv.c:2487:12: note: (near initialization for 'netvsc_drv')
   cc1: some warnings being treated as errors

vim +2486 drivers/net/hyperv/netvsc_drv.c

  2479	
  2480	/* The one and only one */
  2481	static struct  hv_driver netvsc_drv = {
  2482		.name = KBUILD_MODNAME,
  2483		.id_table = id_table,
  2484		.probe = netvsc_probe,
  2485		.remove = netvsc_remove,
> 2486		.suspend = netvsc_suspend,
> 2487		.resume = netvsc_resume,
  2488		.driver = {
  2489			.probe_type = PROBE_FORCE_SYNCHRONOUS,
  2490		},
  2491	};
  2492	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (48169 bytes)